-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure time.Time comparison produces a helpful diff. closes #989 #1072
Conversation
Ping @AlekSi @Jozmen @boyan-soubachov |
Hi, could we please get some attention on this one? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this :)
@boyan-soubachov Thanks for approving :)) |
@boyan-soubachov Can we please get a |
I will keep this in |
Make sure time.Time comparison produces a helpful diff. closes #989
Summary
Make sure time.Time comparison produces a helpful diff
again. This partially reverses the changes in #895 for
time.Time and allows it to be easily expanded for more
types in the future if needed.
Changes
Analyzes the type when diffing, and uses a different
Spew config for time.Time
Introduce a test for diffing time.Time
Motivation
See bug #989
Related issues
Closes #989