-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go.mod and go.modverify #607
Conversation
Works for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go.mod versions do not match Gopkg.lock
I tried to do this myself, but vgo
is panicking for me when trying to add github.com/stretchr/objx
.
I can update the files to be correct, but it would be ideal if the |
Actually, I don't think that will be enough to make this work. We're still dependent on golang/go#25604 / golang/go#24103. It'd still be good to fix the version on objx though. |
If we can pull some data about the usage of That feature predates my involvement in the project and I have never used it myself and don’t know anybody who has. |
Using vgo latest (sha: |
Note: The reason it defines the version for objx as |
Can we use |
👍 I'll update the PR. |
I've fixed the vgo files so they have proper versions now. stretchr/objx#80 fixed the |
The |
@ernesto-jimenez The It would be ideal if #659 is merged first, but this PR also includes updating |
This branch is now mergeable with master now that #659 is merged. I double checked and it still aligns with the |
What is the status on this PR? |
I'd like to get it merged, it's good to go, I just need someone to review it and merge it. |
This PR is quite dirty. Many commits, including reverts and too many of them are merge commits. Please cleanup: rebase on top of latest master and push again:
|
@dolmen I squashed the changes into a single commit so that it looks more organized for you. Ready to go! |
The build failure looks like it might be related to a change on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 (but I'm not a maintainer)
@ernesto-jimenez Now that #659 has been merged, are we good to merge this? |
@ernesto-jimenez 👋 Is this something we can merge now, or can you tell me if there other things I can address? Or are you wanting to hold off on adopting Go modules? |
What === Add `go.mod` and `go.sum`, using `Go 1.11`. Why === Now that golang/go#24301 has been accepted, lets start using go.mod files alongside Godep, and keep the two in sync. Notes === There are no changes required to testify to support go.mod. The files were generated by running `go build` and `go mod tidy. Merging === This PR is intended to be merged after #659 which adds Go1.11 to the list of supported builds.
Taking a look, I'll get it merged ASAP. |
Thank you for your contribution @leighmcculloch ! |
No worries! Thanks for getting this merged @georgelesica-wf and @benechols-wf !!! |
@georgelesica-wf @benechols-wf What would you think about dropping the existing |
I would prefer to leave them both for now. The deps don't change all that often, and vgo is still very new, so many people won't have it installed, particularly if they typically work with an older version of Go (which we still support). |
FWIW, all currently supported versions of Go and one previous version (Go 1.9.7+, 1.10.3+, and of course Go 1.11) all have at least basic read support for Modules. Anything older than 1.10 isn't getting security patches anymore so it may not be worth going out of your way to maintain support for it. |
What
Add
go.mod
andgo.sum
, usingGo 1.11
.Why
Now that golang/go#24301 has been accepted, lets start using go.mod files
alongside Godep, and keep the two in sync.
Notes
There are no changes required to testify to support go.mod. The files were
generated by running
go build
and `go mod tidy.Merging
This PR is intended to be merged after #659 which adds Go1.11 to the list of
supported builds.