-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go1.11 to CI #659
Add Go1.11 to CI #659
Conversation
I propose to drop support for go 1.8. One and a half year of go is fine. |
@ernesto-jimenez Should I remove Go1.8 too? |
I updated the PR removing 1.8. |
It should be backward compatible, as long as we don't face any issues we could keep the 1.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
👋 What else needs to happen to get this merged? PR #607 is dependent on this. |
@leighmcculloch we're waiting for someone to grant me merge permissions, sorry so slow! |
@ernesto-jimenez @matryer Do either of you have merge access, or able to provide @georgelesica-wf with merge access? ❤️ |
Thanks for merging @georgelesica-wf ! |
Now that this has been merged I've updated #607 (Add go.mod) based on this. |
What === Add `go.mod` and `go.sum`, using `Go 1.11`. Why === Now that golang/go#24301 has been accepted, lets start using go.mod files alongside Godep, and keep the two in sync. Notes === There are no changes required to testify to support go.mod. The files were generated by running `go build` and `go mod tidy. Merging === This PR is intended to be merged after #659 which adds Go1.11 to the list of supported builds.
What
Add Go1.11 to CI.
Why
Go1.11 has been released and should be tested against and supported.