Remove toJson() from StripeJsonModel #1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better reflects its usage for non-authentication scenarios. Also rename related classes and methods.
This is now ready for use. DX-4013
`toJson()` was previously used in the implementation of `equals()` (see #813). Now that it is no longer used in `equals()`, it is no longer needed. Remove all implementations of toJson() and rename StripeJsonModel to StripeModel. Also improve object construction in `AbstractEphemeralKey` by creating a Builder object instead of using reflection.
mshafrir-stripe
force-pushed
the
remove-json
branch
from
3abcad6 to
4e7ca46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove all implementations of toJson() and rename StripeJsonModel
to StripeModel.
Also improve object construction in
AbstractEphemeralKeybycreating a Builder object instead of using reflection.
Motivation
toJson()was previously used in the implementation ofequals()(see #813). Now that it is no longer used in
equals(), it isno longer needed.
Testing
Update tests