Implement equals and hashCode in models #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshafrir-stripe
force-pushed
the
payment-methods
branch
from
3df2511 to
a6bdcb4
Compare
**Summary** Implement `equals()` and `hashCode()` for all models, specifically the subclasses of `StripeJsonModel` **Motivation** The implementation of `equals()`, `hashCode()`, and `toString()` in `StripeJsonModel`, which is the base class of almost all model classes, is extremely inefficient. It implements these methods by first transforming the model object to a JSON string, which is an expensive operation. **Testing** - Updated unit tests - Tested on device with example app
mshafrir-stripe
added a commit
that referenced
this pull request
Jun 10, 2019
`toJson()` was previously used in the implementation of `equals()` (see #813). Now that it is no longer used in `equals()`, it is no longer needed. Remove all implementations of toJson() and rename StripeJsonModel to StripeModel. Also improve object construction in `AbstractEphemeralKey` by creating a Builder object instead of using reflection.
mshafrir-stripe
added a commit
that referenced
this pull request
Jun 10, 2019
`toJson()` was previously used in the implementation of `equals()` (see #813). Now that it is no longer used in `equals()`, it is no longer needed. Remove all implementations of toJson() and rename StripeJsonModel to StripeModel. Also improve object construction in `AbstractEphemeralKey` by creating a Builder object instead of using reflection.
mshafrir-stripe
added a commit
that referenced
this pull request
Jun 10, 2019
`toJson()` was previously used in the implementation of `equals()` (see #813). Now that it is no longer used in `equals()`, it is no longer needed. Remove all implementations of toJson() and rename `StripeJsonModel` to `StripeModel`.
mshafrir-stripe
added a commit
that referenced
this pull request
Jun 10, 2019
`toJson()` was previously used in the implementation of `equals()` (see #813). Now that it is no longer used in `equals()`, it is no longer needed. Remove all implementations of toJson() and rename `StripeJsonModel` to `StripeModel`.
mshafrir-stripe
added a commit
that referenced
this pull request
Jun 10, 2019
`toJson()` was previously used in the implementation of `equals()` (see #813). Now that it is no longer used in `equals()`, it is no longer needed.
mshafrir-stripe
added a commit
that referenced
this pull request
Jun 10, 2019
`toJson()` was previously used in the implementation of `equals()` (see #813). Now that it is no longer used in `equals()`, it is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement
equals()andhashCode()for all models,specifically the subclasses of
StripeJsonModelMotivation
The implementation of
equals(),hashCode(), andtoString()inStripeJsonModel, which is the baseclass of almost all model classes, is extremely
inefficient. It implements these methods by first
transforming the model object to a JSON string, which
is an expensive operation.
Testing