-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GrabPay to PaymentSheet #7198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffuse output:
APK
DEX
ARSC
|
tillh-stripe
requested review from
carlosmuvi-stripe,
porter-stripe,
jameswoo-stripe,
jaynewstrom-stripe and
samer-stripe
and removed request for
carlosmuvi-stripe
August 24, 2023 18:59
jaynewstrom-stripe
previously approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
@@ -2,13 +2,14 @@ | |||
|
|||
## XX.XX.XX - 2023-XX-XX | |||
|
|||
### CustomerSheet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CustomerSheet less important than payment sheet?
jaynewstrom-stripe
approved these changes
Aug 24, 2023
jameswoo-stripe
approved these changes
Aug 24, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds GrabPay for PaymentIntents.
Motivation
All. The. LPMs.
Testing
Screen recording
Recording
grabpay.mp4
Note: The icon will appear once the pay-server pull request is merged.
Changelog
[ADDED] PaymentSheet now supports GrabPay for PaymentIntents.