Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GrabPay to PaymentSheet #7198

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Aug 24, 2023

Summary

This pull request adds GrabPay for PaymentIntents.

Motivation

All. The. LPMs.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screen recording

Recording

grabpay.mp4

Note: The icon will appear once the pay-server pull request is merged.

Changelog

[ADDED] PaymentSheet now supports GrabPay for PaymentIntents.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   3.5 MiB │   3.5 MiB │   +136 B │   7.8 MiB │   7.8 MiB │   +208 B 
     arsc │   2.1 MiB │   2.1 MiB │   +724 B │   2.1 MiB │   2.1 MiB │   +724 B 
 manifest │   4.9 KiB │   4.9 KiB │      0 B │  24.1 KiB │  24.1 KiB │      0 B 
      res │ 866.6 KiB │ 867.5 KiB │   +886 B │   1.3 MiB │   1.3 MiB │ +1.5 KiB 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │    +81 B │     3 MiB │     3 MiB │   +381 B 
    other │ 199.5 KiB │ 199.5 KiB │    +74 B │ 446.3 KiB │ 446.5 KiB │   +164 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.3 MiB │  12.3 MiB │ +1.9 KiB │  20.7 MiB │  20.7 MiB │ +2.9 KiB 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 38245 │ 38246 │ +1 (+2 -1) 
   types │ 12640 │ 12640 │  0 (+0 -0) 
 classes │ 10664 │ 10664 │  0 (+0 -0) 
 methods │ 56024 │ 56024 │  0 (+0 -0) 
  fields │ 35129 │ 35130 │ +1 (+1 -0) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  290 │  290 │  0         
 entries │ 6920 │ 6922 │ +2 (+2 -0)
APK
     compressed      │     uncompressed     │                        
──────────┬──────────┼───────────┬──────────┤                        
 size     │ diff     │ size      │ diff     │ path                   
──────────┼──────────┼───────────┼──────────┼────────────────────────
    889 B │   +889 B │   1.5 KiB │ +1.5 KiB │ + res/lG.xml           
  2.1 MiB │   +724 B │   2.1 MiB │   +724 B │ ∆ resources.arsc       
  3.5 MiB │   +136 B │   7.8 MiB │   +208 B │ ∆ classes.dex          
  2.3 KiB │    +81 B │  18.5 KiB │   +381 B │ ∆ assets/lpms.json     
 48.4 KiB │    +44 B │ 140.6 KiB │    +82 B │ ∆ META-INF/MANIFEST.MF 
 62.6 KiB │    +31 B │ 140.7 KiB │    +82 B │ ∆ META-INF/CERT.SF     
    997 B │     -2 B │   2.8 KiB │      0 B │ ∆ res/XB.xml           
    950 B │     -1 B │   2.5 KiB │      0 B │ ∆ res/9N.xml           
  1.2 KiB │     -1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────────┼───────────┼──────────┼────────────────────────
  5.8 MiB │ +1.9 KiB │  10.2 MiB │ +2.9 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   38245 │ 38246 │ +1 (+2 -1) 
  + SGD
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:9d045c9,r8-mode:full,version:8.0.46}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:4e2bcf1,r8-mode:full,version:8.0.46}
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   35129 │ 35130 │ +1 (+1 -0) 
  + me.a0 t: z
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6920 │ 6922 │ +2 (+2 -0) 
  + drawable/stripe_ic_paymentsheet_pm_grabpay
  + string/stripe_paymentsheet_payment_method_grabpay

@tillh-stripe tillh-stripe marked this pull request as ready for review August 24, 2023 18:59
@tillh-stripe tillh-stripe requested review from a team as code owners August 24, 2023 18:59
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@@ -2,13 +2,14 @@

## XX.XX.XX - 2023-XX-XX

### CustomerSheet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CustomerSheet less important than payment sheet?

@tillh-stripe tillh-stripe enabled auto-merge (squash) August 24, 2023 19:20
@tillh-stripe tillh-stripe disabled auto-merge August 24, 2023 19:20
@tillh-stripe tillh-stripe merged commit 9de5eee into master Aug 24, 2023
@tillh-stripe tillh-stripe deleted the tillh/grabpay-in-paymentsheet branch August 24, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants