Update Emerge tools integration to use latest best practices #9001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbro112
requested review from
tillh-stripe,
awush-stripe and
jaynewstrom-stripe
|
|
amk-stripe
reviewed
Sep 3, 2024
.github/workflows/push.yml
Outdated
| artifact_path: paymentsheet-example/build/outputs/bundle/release/paymentsheet-example-release.aab | ||
| emerge_api_key: ${{ secrets.EMERGE_API_KEY }} | ||
| build_type: push | ||
| - name: Upload Financial Connections example release bundle to Emerge |
There was a problem hiding this comment.
I think the name on this one might be incorrect -- it says "Financial connections" but the name of this step is for payment sheet
There was a problem hiding this comment.
Good spot - updated!
amk-stripe
previously approved these changes
Sep 5, 2024
amk-stripe
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates Emerge Tools integration to use best practices. Emerge has deprecated the GitHub action for Android in favor of the Gradle plugin.
I was also curious about incorporating Emerge snapshot testing. See emerge-android #2 for an example of that - happy to add that as well if Stripe is interested in trying Emerge's snapshot testing.
Motivation
We're doing this as Stripe recently reached out about an issue with their existing integration. We noticed a few old practices being used, so we figured we'd help update everything to the latest and greatest 😄 .
Testing
Screenshots
N/A
Changelog
N/A