Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Emerge tools integration to use latest best practices #9254

Closed
wants to merge 11 commits into from

Conversation

amk-stripe
Copy link
Collaborator

Summary

Update Emerge tools integration to use latest best practices

Original public PR: #9001

Copy link
Contributor

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

@amk-stripe amk-stripe added the accept-risky-change accept-risky-change label Sep 12, 2024
Copy link
Contributor

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   1.9 MiB │   1.9 MiB │  0 B │     4 MiB │     4 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.8 KiB │   6.8 KiB │  0 B │   6.6 KiB │   6.6 KiB │  0 B 
    other │  85.5 KiB │  85.5 KiB │ +5 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.5 MiB │   9.5 MiB │ +5 B │  21.4 MiB │  21.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20269 │ 20269 │ 0 (+0 -0) 
   types │  6106 │  6106 │ 0 (+0 -0) 
 classes │  4913 │  4913 │ 0 (+0 -0) 
 methods │ 29561 │ 29561 │ 0 (+0 -0) 
  fields │ 17371 │ 17371 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3608 │ 3608 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 25.1 KiB │ +4 B │  62.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │ +3 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
 28.3 KiB │ -2 B │  62.6 KiB │  0 B │ ∆ META-INF/CERT.SF     
──────────┼──────┼───────────┼──────┼────────────────────────
 54.6 KiB │ +5 B │ 126.3 KiB │  0 B │ (total)

@amk-stripe amk-stripe marked this pull request as ready for review September 12, 2024 23:05
@amk-stripe amk-stripe requested review from a team as code owners September 12, 2024 23:05
@amk-stripe amk-stripe marked this pull request as draft September 12, 2024 23:10
@amk-stripe
Copy link
Collaborator Author

Original PR was merged

@amk-stripe amk-stripe closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accept-risky-change accept-risky-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants