Add deprecated annotation to primary BI classes

[amk-stripe]

Summary

Add deprecated annotation to primary BI classes

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2461

An in-SDK heads-up about upcoming removal of BI

Testing

• Added tests
• Modified tests
• Manually verified

Changelog

Basic integration

• [DEPRECATED]9433 Basic integration is now deprecated and will be removed in a future release. Please use Mobile Payment Element instead.

[github-actions]

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │         uncompressed         
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────
      dex │   3.9 MiB │   3.9 MiB │ -240 B │   8.6 MiB │   8.6 MiB │ +4 B 
     arsc │   2.3 MiB │   2.3 MiB │    0 B │   2.3 MiB │   2.3 MiB │  0 B 
 manifest │   5.1 KiB │   5.1 KiB │    0 B │  25.6 KiB │  25.6 KiB │  0 B 
      res │ 933.6 KiB │ 933.6 KiB │    0 B │   1.5 MiB │   1.5 MiB │  0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │  0 B 
    asset │   2.9 MiB │   2.9 MiB │    0 B │   2.9 MiB │   2.9 MiB │  0 B 
    other │   196 KiB │   196 KiB │   +5 B │ 430.6 KiB │ 430.6 KiB │  0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────
    total │  12.8 MiB │  12.8 MiB │ -235 B │  21.7 MiB │  21.7 MiB │ +4 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 42653 │ 42653 │ 0 (+1 -1) 
   types │ 14149 │ 14149 │ 0 (+0 -0) 
 classes │ 11775 │ 11775 │ 0 (+0 -0) 
 methods │ 60444 │ 60444 │ 0 (+0 -0) 
  fields │ 40076 │ 40076 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6252 │ 6252 │  0

APK

    compressed     │   uncompressed   │                        
──────────┬────────┼───────────┬──────┤                        
 size     │ diff   │ size      │ diff │ path                   
──────────┼────────┼───────────┼──────┼────────────────────────
  3.9 MiB │ -240 B │   8.6 MiB │ +4 B │ ∆ classes.dex          
  1.2 KiB │   +3 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
 50.1 KiB │   +3 B │ 118.2 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
 53.4 KiB │   -1 B │ 118.3 KiB │  0 B │ ∆ META-INF/CERT.SF     
──────────┼────────┼───────────┼──────┼────────────────────────
    4 MiB │ -235 B │   8.8 MiB │ +4 B │ (total)

DEX

STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   42653 │ 42653 │ 0 (+1 -1) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"014f6f8","r8-mode":"full","version":"8.5.35"}
  
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"3314f55","r8-mode":"full","version":"8.5.35"}

[jaynewstrom-stripe]

Can we add this string as a constant, and reference it in all of these?

[amk-stripe]

yep! Done, thanks

[jaynewstrom-stripe]

Why do we test this in PaymentSheet?

[amk-stripe]

Good question! We aren't actually testing the activity itself, we are just using it to test out our functions that take in an activity as a parameter, e.g. the FlowControllerFactory constructor. We should be using an example activity for that, rather than using the BI activities. I will follow up and update those tests

[jaynewstrom-stripe]

Thanks!

[amk-stripe]

#9453