Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete paymentsheet ActivityScenarioFactory.kt #9453

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

amk-stripe
Copy link
Collaborator

Summary

Delete paymentsheet ActivityScenarioFactory.kt

Motivation

This implementation of ActivityScenarioFactory relies on AddPaymentMethodActivity, which is being deleted as part of BI deprecation. This work is necessary to ensure our tests keep working after we delete AddPaymentMethodActivity

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   1.9 MiB │   1.9 MiB │  0 B │     4 MiB │     4 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.8 KiB │   6.8 KiB │  0 B │   6.6 KiB │   6.6 KiB │  0 B 
    other │  85.5 KiB │  85.5 KiB │  0 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.5 MiB │   9.5 MiB │  0 B │  21.4 MiB │  21.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20252 │ 20252 │ 0 (+0 -0) 
   types │  6082 │  6082 │ 0 (+0 -0) 
 classes │  4886 │  4886 │ 0 (+0 -0) 
 methods │ 29463 │ 29463 │ 0 (+0 -0) 
  fields │ 17389 │ 17389 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3608 │ 3608 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 28.3 KiB │ +2 B │  62.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    271 B │ -1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 25.1 KiB │ -1 B │  62.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 53.7 KiB │  0 B │ 125.2 KiB │  0 B │ (total)

@amk-stripe amk-stripe marked this pull request as ready for review October 16, 2024 16:45
@amk-stripe amk-stripe requested review from a team as code owners October 16, 2024 16:45
@amk-stripe amk-stripe requested review from samer-stripe and jaynewstrom-stripe and removed request for samer-stripe October 16, 2024 16:45
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@amk-stripe amk-stripe enabled auto-merge (squash) October 16, 2024 17:04
@amk-stripe amk-stripe merged commit 785b193 into master Oct 16, 2024
13 checks passed
@amk-stripe amk-stripe deleted the delete-ps-activity-scenario-factory branch October 16, 2024 18:51
amk-stripe added a commit that referenced this pull request Oct 22, 2024
* Delete paymentsheet ActivityScenarioFactory.kt

* Fix warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants