"Card details cannot be changed" text size closer to form label size #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,7 +100,7 @@ import UIKit | |||
| withTextStyle: .caption1, | |||
| maximumPointSize: 20) | |||
| public var footnote = UIFont.preferredFont(forTextStyle: .footnote, weight: .regular, maximumPointSize: 20) | |||
| public var smallFootnote = UIFont.preferredFont(forTextStyle: .footnote, weight: .medium, maximumPointSize: 10) | |||
| public var smallFootnote = UIFontMetrics(forTextStyle: .footnote).scaledFont(for: .systemFont(ofSize: 10.5, weight: .medium)) | |||
There was a problem hiding this comment.
My slight preference is to not use half point sizes, and prefer the text styles. Can we get away with using caption2, it's 11.
There was a problem hiding this comment.
My assumption is that we'd want the sublabel and the error text to be the same size— is that right? If so, I'm currently sending Hannah a screenshot with the error text set to caption2, and if she says that's okay, then we can go through with it.
porter-stripe
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed smallFootnote to font size 11.5
The form label font is subheadline, but when the field has text or is being edited, it moves up and scales to 75%. I tried making the smallFootnote font subheadline and scaling it, but it scaled the label position. 75% of 14pt is 10.5
Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-2878
Testing
Changelog