Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Card details cannot be changed" text size closer to form label size #4372

Merged
merged 9 commits into from
Dec 20, 2024
+1 −1
Merged

"Card details cannot be changed" text size closer to form label size #4372

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a248252
changed font size of details cannot be changed footnote
joyceqin-stripe Dec 18, 2024
52b411f
remove print
joyceqin-stripe Dec 18, 2024
7834b11
Merge branch 'master' into joyceqin-MOBILESDK-2878
joyceqin-stripe Dec 19, 2024
3fb3483
Merge branch 'master' into joyceqin-MOBILESDK-2878
joyceqin-stripe Dec 19, 2024
1915e08
made font of smallfootnote .5 smaller
joyceqin-stripe Dec 19, 2024
4fa01d9
Merge branch 'master' into joyceqin-MOBILESDK-2878
joyceqin-stripe Dec 19, 2024
dc1e4df
caption2
joyceqin-stripe Dec 20, 2024
b2983d9
Merge branch 'master' into joyceqin-MOBILESDK-2878
joyceqin-stripe Dec 20, 2024
842bd3c
Merge branch 'master' into joyceqin-MOBILESDK-2878
joyceqin-stripe Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion StripeUICore/StripeUICore/Source/Elements/ElementsUI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ import UIKit
withTextStyle: .caption1,
maximumPointSize: 20)
public var footnote = UIFont.preferredFont(forTextStyle: .footnote, weight: .regular, maximumPointSize: 20)
public var smallFootnote = UIFont.preferredFont(forTextStyle: .footnote, weight: .medium, maximumPointSize: 10)
public var smallFootnote = UIFontMetrics(forTextStyle: .footnote).scaledFont(for: .systemFont(ofSize: 10.5, weight: .medium))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My slight preference is to not use half point sizes, and prefer the text styles. Can we get away with using caption2, it's 11.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My assumption is that we'd want the sublabel and the error text to be the same size— is that right? If so, I'm currently sending Hannah a screenshot with the error text set to caption2, and if she says that's okay, then we can go through with it.

public var footnoteEmphasis = UIFont.preferredFont(forTextStyle: .footnote, weight: .medium, maximumPointSize: 20)
}

Expand Down
Binary file modified ...ests/test_EmbeddedSingleCard_UpdatePaymentMethodViewControllerAppearance@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...tTests/test_EmbeddedSingleCard_UpdatePaymentMethodViewControllerDarkMode@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...Tests/test_EmbeddedSingleCard_UpdatePaymentMethodViewControllerLightMode@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...test_EmbeddedSingleSEPADebit_UpdatePaymentMethodViewControllerAppearance@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/test_EmbeddedSingleSEPADebit_UpdatePaymentMethodViewControllerDarkMode@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../test_EmbeddedSingleSEPADebit_UpdatePaymentMethodViewControllerLightMode@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ..._EmbeddedSingleUSBankAccount_UpdatePaymentMethodViewControllerAppearance@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...st_EmbeddedSingleUSBankAccount_UpdatePaymentMethodViewControllerDarkMode@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...t_EmbeddedSingleUSBankAccount_UpdatePaymentMethodViewControllerLightMode@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ControllerSnapshotTests/test_UpdatePaymentMethodViewControllerAppearance@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ewControllerSnapshotTests/test_UpdatePaymentMethodViewControllerDarkMode@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...wControllerSnapshotTests/test_UpdatePaymentMethodViewControllerLightMode@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...rollerSnapshotTests/test_UpdatePaymentMethodViewControllerRemoveOnlyCard@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...rSnapshotTests/test_UpdatePaymentMethodViewControllerSEPADebitAppearance@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...lerSnapshotTests/test_UpdatePaymentMethodViewControllerSEPADebitDarkMode@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...erSnapshotTests/test_UpdatePaymentMethodViewControllerSEPADebitLightMode@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...pshotTests/test_UpdatePaymentMethodViewControllerUSBankAccountAppearance@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...napshotTests/test_UpdatePaymentMethodViewControllerUSBankAccountDarkMode@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...apshotTests/test_UpdatePaymentMethodViewControllerUSBankAccountLightMode@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading