Update StripeConnect's FinancialConnections integration to work with public key override.

[nschris-stripe]

Summary

• Ensures the financial connection integration uses the public key override.
• Updates implementation to make it more testable.

[github-actions]

🚨 New dead code detected in this PR:

FinancialConnectionsPresenter.swift:21 warning: Parameter 'presentingViewController' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

[mludowise-stripe]

lgtm -- not sure if you wanted to add an xctassertequal on the client secret. If so, lmk and I'll reshipit

[mludowise-stripe]

Looks like testOpenFinancialConnections tests need to get updated ConnectComponentWebViewControllerTests. Looks like they're failing because the method signature changed for overridePresentForToken

[mludowise-stripe]

Doublechecking – STPAPIClient subclasses NSObject and doesn't override isEqual, so I think this should just do pointer-comparison, right? Just want to make sure the equality comparison does what we think it should.

Non-blocking: Also, if we're using == anyway, this could be XCTAssertEqual which would provide a better failure message if the test fails.

Suggested change

	XCTAssert(compManager.apiClient == componentManager.apiClient)
	XCTAssert(compManager.publicKeyOverride == componentManager.publicKeyOverride)
	XCTAssertEqual(compManager.apiClient, componentManager.apiClient)
	XCTAssertEqual(compManager.publicKeyOverride, componentManager.publicKeyOverride)

[nschris-stripe]

Yeah this should be doing pointer comparison.

[emerge-tools]

📸 Snapshot Test

No snapshots generated

Name	Added	Removed	Modified	Unchanged	Errored	Approval
StripePaymentsUISize com.stripe.StripePaymentsUISize	0	0	0	0	0	N/A
StripeApplePaySize com.stripe.StripeApplePaySize	0	0	0	0	0	N/A
StripeSize com.stripe.StripeSize	0	0	0	0	0	N/A
StripePaymentSheetSize com.stripe.StripePaymentSheetSize	0	0	0	0	0	N/A
StripeIdentitySize com.stripe.StripeIdentitySize	0	0	0	0	0	N/A
StripePaymentsSize com.stripe.StripePaymentsSize	0	0	0	0	0	N/A
StripeFinancialConnectionsSize com.stripe.StripeFinancialConnectionsSize	0	0	0	0	0	N/A
StripeConnectSize com.stripe.StripeConnectSize	0	0	0	0	0	N/A

---

🛸 Powered by Emerge Tools