-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update StripeConnect's FinancialConnections integration to work with public key override. #4379
Merged
nschris-stripe
merged 5 commits into
master
from
nschris/fixFinancialConnectionsDashboard
Dec 21, 2024
+94
−14
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b514231
Update stripe connect integration to work with public key override.
nschris-stripe 179d0ec
Merge branch 'master' into nschris/fixFinancialConnectionsDashboard
nschris-stripe 2413d51
Merge branch 'master' into nschris/fixFinancialConnectionsDashboard
nschris-stripe d02cfe7
Merge branch 'master' into nschris/fixFinancialConnectionsDashboard
nschris-stripe 79ef68d
Merge branch 'master' into nschris/fixFinancialConnectionsDashboard
nschris-stripe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
StripeConnect/StripeConnectTests/Internal/FinancialConnectionsPresenterTests.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // | ||
| // FinancialConnectionsPresenterTests.swift | ||
| // StripeConnect | ||
| // | ||
| // Created by Chris Mays on 12/18/24. | ||
| // | ||
| @_spi(PrivateBetaConnect) @_spi(DashboardOnly) @testable import StripeConnect | ||
| @testable import StripeFinancialConnections | ||
|
|
||
| import UIKit | ||
| import XCTest | ||
|
|
||
| class FinancialConnectionsPresenterTests: XCTestCase { | ||
|
|
||
| @MainActor | ||
| func testStandardPresent() { | ||
| let presenter = FinancialConnectionsPresenter() | ||
|
|
||
| let clientSecret = "client_secret" | ||
| let connectedAccountId = "account_1234" | ||
| let publishableKey = "pk_12" | ||
|
|
||
| let componentManager = EmbeddedComponentManager(apiClient: .init(publishableKey: publishableKey), | ||
| appearance: .default, | ||
| fonts: [], | ||
| fetchClientSecret: {return nil}) | ||
|
|
||
| let sheet = presenter.makeSheet(componentManager: componentManager, clientSecret: clientSecret, connectedAccountId: connectedAccountId, from: .init()) | ||
|
|
||
| XCTAssertEqual(sheet.apiClient.publishableKey, publishableKey) | ||
| XCTAssertEqual(sheet.apiClient.stripeAccount, connectedAccountId) | ||
| } | ||
|
|
||
| @MainActor | ||
| func testPresentWithPublicKeyOverride() { | ||
| let clientSecret = "client_secret" | ||
| let connectedAccountId = "account_1234" | ||
| let ukKey = "uk_123" | ||
| let publishableKey = "pk_12" | ||
|
|
||
| let presenter = FinancialConnectionsPresenter() | ||
| let componentManager = EmbeddedComponentManager(apiClient: .init(publishableKey: ukKey), | ||
| appearance: .default, | ||
| publicKeyOverride: publishableKey, | ||
| baseURLOverride: nil) | ||
|
|
||
| let sheet = presenter.makeSheet(componentManager: componentManager, clientSecret: clientSecret, connectedAccountId: connectedAccountId, from: .init()) | ||
|
|
||
|
|
||
| XCTAssertEqual(sheet.apiClient.publishableKey, publishableKey) | ||
| XCTAssertEqual(sheet.apiClient.stripeAccount, connectedAccountId) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doublechecking – STPAPIClient subclasses NSObject and doesn't override
isEqual, so I think this should just do pointer-comparison, right? Just want to make sure the equality comparison does what we think it should.Non-blocking: Also, if we're using
==anyway, this could beXCTAssertEqualwhich would provide a better failure message if the test fails.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this should be doing pointer comparison.