Bail to web-based Link when needed #4435
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary <!-- Simple summary of what was changed. --> This pull request fixes a snapshot issue introduced in #4363. ## Motivation <!-- Why are you making this change? If it's for fixing a bug, if possible, please include a code snippet or example project that demonstrates the issue. --> ## Testing <!-- How was the code tested? Be as specific as possible. --> ## Changelog <!-- Is this a notable change that affects users? If so, add a line to `CHANGELOG.md` and prefix the line with one of the following: - [Added] for new features. - [Changed] for changes in existing functionality. - [Deprecated] for soon-to-be removed features. - [Removed] for now removed features. - [Fixed] for any bug fixes. - [Security] in case of vulnerabilities. -->
## Summary
<!-- Simple summary of what was changed. -->
This pull request removes the space before the last4 again for bank and
SEPA.
## Motivation
<!-- Why are you making this change? If it's for fixing a bug, if
possible, please include a code snippet or example project that
demonstrates the issue. -->
## Testing
<!-- How was the code tested? Be as specific as possible. -->
## Changelog
<!-- Is this a notable change that affects users? If so, add a line to
`CHANGELOG.md` and prefix the line with one of the following:
- [Added] for new features.
- [Changed] for changes in existing functionality.
- [Deprecated] for soon-to-be removed features.
- [Removed] for now removed features.
- [Fixed] for any bug fixes.
- [Security] in case of vulnerabilities.
-->
…public key override. (#4379) ## Summary - Ensures the financial connection integration uses the public key override. - Updates implementation to make it more testable.
## Summary - Grabs the latest Swish and Revolut Pay assets  <!-- How was the code tested? Be as specific as possible. -->    ## Motivation https://jira.corp.stripe.com/browse/RUN_MOBILESDK-3758 ## Testing - Manual ## Changelog N/A
## Summary <!-- Simple summary of what was changed. --> Error text now 11pt (caption2) 8px after form instead of 4 ## Motivation <!-- Why are you making this change? If it's for fixing a bug, if possible, please include a code snippet or example project that demonstrates the issue. --> https://jira.corp.stripe.com/browse/MOBILESDK-2884 ## Testing <!-- How was the code tested? Be as specific as possible. -->  ## Changelog <!-- Is this a notable change that affects users? If so, add a line to `CHANGELOG.md` and prefix the line with one of the following: - [Added] for new features. - [Changed] for changes in existing functionality. - [Deprecated] for soon-to-be removed features. - [Removed] for now removed features. - [Fixed] for any bug fixes. - [Security] in case of vulnerabilities. -->
## Summary <!-- Simple summary of what was changed. --> Remove button border width matches selectedBorderWidth, font matches Save button. ## Motivation <!-- Why are you making this change? If it's for fixing a bug, if possible, please include a code snippet or example project that demonstrates the issue. --> https://jira.corp.stripe.com/browse/MOBILESDK-2882 ## Testing <!-- How was the code tested? Be as specific as possible. -->  ## Changelog <!-- Is this a notable change that affects users? If so, add a line to `CHANGELOG.md` and prefix the line with one of the following: - [Added] for new features. - [Changed] for changes in existing functionality. - [Deprecated] for soon-to-be removed features. - [Removed] for now removed features. - [Fixed] for any bug fixes. - [Security] in case of vulnerabilities. -->
…omatic (#4424) ## Summary See title ## Motivation It's the default API now so our playground should match.
…4425) ## Motivation Matches the default API value
…4373) ## Summary <!-- Simple summary of what was changed. --> Added a translucent mask over componentBackground color to make a disabled appearance ## Motivation <!-- Why are you making this change? If it's for fixing a bug, if possible, please include a code snippet or example project that demonstrates the issue. --> https://jira.corp.stripe.com/browse/MOBILESDK-2880 ## Testing <!-- How was the code tested? Be as specific as possible. -->    ## Changelog <!-- Is this a notable change that affects users? If so, add a line to `CHANGELOG.md` and prefix the line with one of the following: - [Added] for new features. - [Changed] for changes in existing functionality. - [Deprecated] for soon-to-be removed features. - [Removed] for now removed features. - [Fixed] for any bug fixes. - [Security] in case of vulnerabilities. -->
## Summary If the Link button is set to show the user's email address, then the user logs out, the button would be blank. This is because we forgot to unset `isHidden` on the payWithLink logo view when updating the UI. ## Testing Manually in PS Example, and added a snapshot test.
## Summary When the signup view appears, select the email field if it isn't already populated.< ## Testing In PS Example
|
🚨 New dead code detected in this PR: FinancialConnectionsPresenter.swift:21 warning: Parameter 'presentingViewController' is unused
PayWithLinkViewController-SignUpViewController.swift:244 warning: Parameter 'attestionError' is unused
PayWithLinkViewController-SignUpViewModel.swift:23 warning: Parameter 'attestionError' is unused
PayWithNativeLinkController.swift:126 warning: Parameter 'payWithLinkWebController' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Changelog