fix: additional guards on entrypoint macro #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinasab
force-pushed
the
sina/fix-entrypoint-macro
branch
2 times, most recently
from
216688e
to
16e5354
Compare
These additional checks ensure attempting to run an sp1 program on a non-zkvm host will silently noop instead of error.
sinasab
force-pushed
the
sina/fix-entrypoint-macro
branch
from
16e5354
to
9da7a8f
Compare
yuwen01
approved these changes
Oct 22, 2024
ratankaliani
pushed a commit
that referenced
this pull request
Oct 30, 2024
Co-authored-by: Yuwen Zhang <yuwen01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These additional checks ensure attempting to run an sp1 program on a non-zkvm host will silently noop instead of error.