Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entrypoint): tests fail on program crates #1687

Closed
wants to merge 2 commits into from
Closed

Conversation

yuwen01
Copy link
Contributor

@yuwen01 yuwen01 commented Oct 22, 2024

  • cargo test usually creates a new "fn main" to be the entry point for running tests

  • when we use !#[no_main] the test harness has unexpected behavior and just calls our main function

  • you cant just not have a main symbol because rustc will complain

  • compilation is currently broken in the template repo, and was fixed here 1c1f84d

  • if were not targeting the zkvm, we return an empty main function that has return values that the harness will expect

  • todo: ux? We should add a log somewhere if a user does try to make tests in the program crate

Originally from #1661

@yuwen01 yuwen01 changed the title ci: nathans changes fix(entrypoint): tests fail on program crates Oct 22, 2024
Copy link

SP1 Performance Test Results

Branch: yuwen/nathan-ci
Commit: d8f8059a
Author: yuwen01

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.17 2.62 0.45 25s
ssz-withdrawals 2757356 10.87 116.73 38.09 1m13s
tendermint 12593597 5.38 237.25 106.84 2m0s

@yuwen01
Copy link
Contributor Author

yuwen01 commented Oct 22, 2024

#1659 CI is cooked in this PR, so i merged this one instead

@yuwen01 yuwen01 closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant