-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sp1-build): default docker tag #1693
Open
ratankaliani
wants to merge
14
commits into
main
Choose a base branch
from
ratan/fix-default-docker-tag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SP1 Performance Test Results Branch: ratan/fix-default-docker-tag
|
Co-authored-by: Yuwen Zhang <yuwen01@gmail.com>
ratankaliani
force-pushed
the
ratan/fix-default-docker-tag
branch
from
October 30, 2024 18:51
5b4b5d2
to
2722e26
Compare
nhtyy
added
the
maybe-stale
A pr or issue that hasnt seen alot of activity recently
label
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The default Docker tag for SP1 was incorrectly set to latest, which caused issues due to caching. The latest tag doesn’t guarantee users will get the most up-to-date container, as their Docker daemon may use a cached version. This caused problems, like outdated dependencies, such as the Rust toolchain (v1.75).
Fixes
SP1_CIRCUIT_VERSION
str file. Whenever we do a new release,SP1_CIRCUIT_VERSION
should be updated.3.0.0
rather than2.0.0
.Source
I detected this issue because the Rust toolchain version inside of this container was quite outdated (1.75), so some of my dependencies were failing to build because of their MSRV.
Every time we push to main, this workflow releases a tag called
main
, as well as a release for the corresponding version tag.sp1/.github/workflows/docker-publish.yml
Lines 64 to 76 in 4cac73b