-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate components to CSS Modules #2163
Conversation
Storybook uses Babel under the hood which seems to choke on the large bundle that's generated by Vite.
🦋 Changeset detectedLatest commit: e11025e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## next #2163 +/- ##
==========================================
- Coverage 97.03% 96.48% -0.55%
==========================================
Files 265 255 -10
Lines 25142 19882 -5260
Branches 2277 1860 -417
==========================================
- Hits 24396 19183 -5213
+ Misses 738 691 -47
Partials 8 8
|
db590ad
to
e016232
Compare
e016232
to
29d2b99
Compare
6da4c58
to
9636d68
Compare
9636d68
to
1fb4fc1
Compare
1fb4fc1
to
9fe910c
Compare
36e4882
to
350b972
Compare
350b972
to
14de555
Compare
4b929f7
to
94dbee5
Compare
Implements #2153.
Purpose
From the RFC:
Approach and changes
@sumup/circuit-ui/styles.css
.<ComponentName>.module.css
filesutilClasses
export instead.BaseStyles
component. The base styles are included in@sumup/circuit-ui/styles.css
.search
type and focus is returned to the input after clearing the value.IconsManifest
type exported from@sumup/icons
.Definition of done