Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display and transition of Carousel slides #2434

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Feb 8, 2024

Purpose

The display and transition of Carousel slides have been broken since v7 😳

The first slide is displayed permanently due to not 1, not 2, but 3 bugs introduced in the migration to CSS Modules (#2163) 😬

Approach and changes

  • Fix display and transition of Carousel slides

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Feb 8, 2024
@connor-baer connor-baer requested a review from a team as a code owner February 8, 2024 17:24
Copy link

changeset-bot bot commented Feb 8, 2024

🦋 Changeset detected

Latest commit: 7202b5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Feb 8, 2024 5:24pm

@connor-baer connor-baer merged commit 789d796 into main Feb 8, 2024
12 checks passed
@connor-baer connor-baer deleted the fix/carousel branch February 8, 2024 17:26
@connor-baer connor-baer mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant