Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove release preset #752

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Remove release preset #752

merged 3 commits into from
Dec 16, 2022

Conversation

connor-baer
Copy link
Member

Purpose

The release preset configured semantic-release to automatically version and publish a package.

In many of our projects, we've switched to using changesets instead. It supports monorepos and provides a more flexible, human-centric workflow. There's little benefit in adding support for changesets to Foundry: its configuration is straight-forward and differs between projects.

Approach and changes

  • Remove the release preset and the semantic-release config
  • Configure changesets for Foundry

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #752 (86fbcb1) into next (d1cba28) will decrease coverage by 0.03%.
The diff coverage is 70.31%.

@@            Coverage Diff             @@
##             next     #752      +/-   ##
==========================================
- Coverage   69.03%   69.00%   -0.04%     
==========================================
  Files          19       21       +2     
  Lines         281      400     +119     
  Branches       42       65      +23     
==========================================
+ Hits          194      276      +82     
- Misses         86      124      +38     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
src/cli/init.ts 22.68% <22.68%> (-11.93%) ⬇️
src/configs/ci/index.ts 42.85% <42.85%> (ø)
src/lib/logger.ts 37.50% <58.33%> (-2.50%) ⬇️
src/lib/files.ts 88.63% <88.63%> (+48.63%) ⬆️
src/configs/lint-staged/config.ts 90.00% <88.88%> (-0.91%) ⬇️
src/lib/options.ts 92.45% <92.45%> (ø)
src/configs/eslint/config.ts 95.00% <95.00%> (-2.62%) ⬇️
src/cli/defaults.ts 100.00% <100.00%> (ø)
src/configs/ci/github-actions.ts 100.00% <100.00%> (ø)
src/configs/eslint/index.ts 100.00% <100.00%> (+50.00%) ⬆️
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@connor-baer connor-baer requested a review from a team as a code owner December 16, 2022 11:51
@connor-baer connor-baer requested review from tareqlol and removed request for a team December 16, 2022 11:51
@connor-baer connor-baer merged commit f6ef551 into next Dec 16, 2022
@connor-baer connor-baer deleted the feature/changesets branch December 16, 2022 11:54
@connor-baer connor-baer added this to the 6.0 milestone Dec 16, 2022
@connor-baer connor-baer mentioned this pull request Apr 3, 2023
3 tasks
This was referenced Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant