Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the concept of "presets" #862

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Remove the concept of "presets" #862

merged 2 commits into from
Apr 20, 2023

Conversation

connor-baer
Copy link
Member

Purpose

After the removal of the "ci" (#754) and "release" (#752) presets, only the "lint" preset is left. To simplify the initialization and configuration of Foundry, we can remove the concept of presets altogether.

Approach and changes

  • Remove the presets option from the CLI arguments and prompts
  • Update the documentation

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

@connor-baer connor-baer requested a review from a team as a code owner April 19, 2023 09:30
@connor-baer connor-baer requested review from tareqlol and removed request for a team April 19, 2023 09:30
@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023

🦋 Changeset detected

Latest commit: a60b637

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/foundry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #862 (a60b637) into main (3018a51) will decrease coverage by 0.58%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
- Coverage   68.58%   68.01%   -0.58%     
==========================================
  Files          18       18              
  Lines         382      372      -10     
  Branches       64       63       -1     
==========================================
- Hits          262      253       -9     
+ Misses        111      110       -1     
  Partials        9        9              
Impacted Files Coverage Δ
src/cli/defaults.ts 100.00% <ø> (ø)
src/lib/choices.ts 100.00% <ø> (ø)
src/presets/index.ts 100.00% <ø> (ø)
src/types/shared.ts 100.00% <ø> (ø)
src/cli/init.ts 20.17% <28.57%> (-2.52%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@connor-baer connor-baer merged commit ab39701 into main Apr 20, 2023
@connor-baer connor-baer deleted the feature/simplify-presets branch April 20, 2023 09:19
@connor-baer connor-baer mentioned this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant