Remove ci preset
#754
Merged
Remove ci preset
#754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 180dd90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## next #754 +/- ##
==========================================
- Coverage 69.00% 68.58% -0.42%
==========================================
Files 21 18 -3
Lines 400 382 -18
Branches 65 64 -1
==========================================
- Hits 276 262 -14
+ Misses 124 120 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
This was referenced Apr 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The
cipreset provided a template for a GitHub Actions workflow that would run the various presets and tools that Foundry offers.In many of our projects, we've had to customize the workflow e.g. to run additional tools. This makes it impossible to upgrade the workflow automatically. We're looking into reusing workflows, though this tooling will likely remain internal to SumUp.
Approach and changes
cipreset and the GitHub Actions workflow templateDefinition of done
Unit and integration tests