Bug: signOut function is not completing and thus not creating logout events in log table

[burggraf]

https://github.com/supabase/gotrue-js/blob/4daa22cf30a2fe25bd1df9d9df0061c17d81a691/src/GoTrueClient.ts#L314

The signOut function never calls this.api.signOut because it's first removing the current session with this._removeSession(), then later checks for this.currentSession before calling this.api.signOut, so this.api.signOut never gets called.

Essentially, no logout is ever taking place. The code is only removing the current session.

The result of this is that if you look in the log table you only see login events, even if you log in, log out, log in, log out, etc.

async signOut(): Promise<{ error: Error | null }> {
    this._removeSession()
    this._notifyAllSubscribers('SIGNED_OUT')
    if (this.currentSession) {
      const { error } = await this.api.signOut(this.currentSession.access_token)
      if (error) return { error }
    }
    return { error: null }
  }