Fix/signout not completing #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… event was never logged to the events table
… event was never logged to the events table
inian
requested changes
Apr 10, 2021
src/GoTrueClient.ts
Outdated
| return { error }; | ||
| } else { | ||
| this._removeSession(); | ||
| this._notifyAllSubscribers('SIGNED_OUT')'' |
There was a problem hiding this comment.
There seems to be a extra '' at the end here
| } | ||
| return { error: null } | ||
| return { error: null }; |
There was a problem hiding this comment.
Remove ; to align formatting with the rest of the file.
src/GoTrueClient.ts
Outdated
| } else { | ||
| this._removeSession(); | ||
| this._notifyAllSubscribers('SIGNED_OUT')'' | ||
| return { error: null }; |
There was a problem hiding this comment.
Remove ; to align formatting with the rest of the file.
src/GoTrueClient.ts
Outdated
| @@ -312,13 +312,20 @@ export default class GoTrueClient { | |||
| * For server-side management, you can disable sessions by passing a JWT through to `auth.api.signOut(JWT: string)` | |||
| */ | |||
| async signOut(): Promise<{ error: Error | null }> { | |||
| this._removeSession() | |||
| this._notifyAllSubscribers('SIGNED_OUT') | |||
| // moved below... | |||
phamhieu
requested changes
Apr 10, 2021
|
Good catch! @burggraf Thank you |
phamhieu
requested changes
Apr 12, 2021
Comment on lines
+320
to
+324
| if (error) { | ||
| return { error } | ||
| } else { | ||
| return { error: null } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes: #73
Bug: signOut function is not completing and thus not creating logout events in log table #73
What is the current behavior?
signOut does not complete and no log record is written to the log table
What is the new behavior?
A log record is successfully written.