-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kakao OIDC #1381
feat: add kakao OIDC #1381
Conversation
Looks good, please address the comments on the ID token contents and I'll merge! Thanks! |
Can you link to docs on how the app authentication works? Do you need to setup different client IDs (audiences) like you need with Google and Apple? |
Yes need to setup kakao js key like google, and need additional work as well. I will add it to docs. |
Hi. can we get a eta on this? |
Thanks for your patience with us, do you mind updating the docs with the changes needed to get Kakao OIDC up and running? We should be able to review once the docs are completed - if there's an existing PR that we've missed feel free to link it here and we can review. Let us know! |
I'll update the document soon and get back to you. |
I added a docs! |
Btw @MiryangJung @softmarshmallow, thank you so much for taking the time to write docs. Just to give you an update - one of our team members is testing the flow and once they are done we should be good to go. I know it's probably tiring to wait but we seek your patience - we think this is a good feature to have but we want to ensure that there are no issues with the rollout |
fully understand. Thank you! |
Just an update: I was able to successfully test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally as well and seems fine to me
Note: test this again before next deploy or ping @J0 |
I have reviewed the code, but when will it be applied to the Supabase service? |
@ganer9r merging the PR does not indicate that it's applied to the Supabase service, we need some time to roll it our to the platform which will take at least a week or so |
🤖 I have created a release *beep* *boop* --- ## [2.145.0](v2.144.0...v2.145.0) (2024-03-26) ### Features * add error codes ([#1377](#1377)) ([e4beea1](e4beea1)) * add kakao OIDC ([#1381](#1381)) ([b5566e7](b5566e7)) * clean up expired factors ([#1371](#1371)) ([5c94207](5c94207)) * configurable NameID format for SAML provider ([#1481](#1481)) ([ef405d8](ef405d8)) * HTTP Hook - Add custom envconfig decoding for HTTP Hook Secrets ([#1467](#1467)) ([5b24c4e](5b24c4e)) * refactor PKCE FlowState to reduce duplicate code ([#1446](#1446)) ([b8d0337](b8d0337)) ### Bug Fixes * add http support for https hooks on localhost ([#1484](#1484)) ([5c04104](5c04104)) * cleanup panics due to bad inactivity timeout code ([#1471](#1471)) ([548edf8](548edf8)) * **docs:** remove bracket on file name for broken link ([#1493](#1493)) ([96f7a68](96f7a68)) * impose expiry on auth code instead of magic link ([#1440](#1440)) ([35aeaf1](35aeaf1)) * invalidate email, phone OTPs on password change ([#1489](#1489)) ([960a4f9](960a4f9)) * move creation of flow state into function ([#1470](#1470)) ([4392a08](4392a08)) * prevent user email side-channel leak on verify ([#1472](#1472)) ([311cde8](311cde8)) * refactor email sending functions ([#1495](#1495)) ([285c290](285c290)) * refactor factor_test to centralize setup ([#1473](#1473)) ([c86007e](c86007e)) * refactor mfa challenge and tests ([#1469](#1469)) ([6c76f21](6c76f21)) * Resend SMS when duplicate SMS sign ups are made ([#1490](#1490)) ([73240a0](73240a0)) * unlink identity bugs ([#1475](#1475)) ([73e8d87](73e8d87)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Adds the `kakao` string to the supported `signInWithIdToken` types. Merge after: supabase/auth#1381
Adds support for OIDC login with Kakao via
signInWithIdToken()
.Fixes: