Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LadspaUGen optional #260

Merged
merged 2 commits into from
Oct 18, 2020
Merged

Conversation

gusano
Copy link
Member

@gusano gusano commented Jun 5, 2019

Fixes #259

@patrickdupuis
Copy link
Contributor

I get this error when trying to run cmake -DLADSPA=OFF ..

CMake Error at source/CMakeLists.txt:363 (install):
  install TARGETS given target "ladspalist" which does not exist in this
  directory.

Signed-off-by: Yvan Volochine <yvan.github@gmail.com>
@gusano gusano force-pushed the topic/LadspaUGen branch from bd74a2c to 3f75fa9 Compare June 5, 2019 17:00
@gusano
Copy link
Member Author

gusano commented Jun 5, 2019

@patrickdupuis doh.. I fixed it and force pushed.. sorry for that and thanks for spotting

@patrickdupuis
Copy link
Contributor

Thanks! Tested on Linux.

@mossheim
Copy link
Contributor

mossheim commented Jun 6, 2019

There should be more documentation than this -- maybe a known issues section in the readme?

Signed-off-by: Yvan Volochine <yvan.github@gmail.com>
@gusano
Copy link
Member Author

gusano commented Jun 6, 2019

@brianlheim note added in the readme

@totalgee
Copy link

This frequent source of confusion ("why does scsynth fail to boot on my Linux distro?") came up again in the TidalCycles forums recently:
https://club.tidalcycles.org/t/supercollider-wont-boot/2285

The "solution" of deleting the LADSPA plugin locally was discussed, and I sent a link to this PR. The comment was made that hopefully it would be merged soon... ;-)

@mossheim mossheim merged commit 58a229d into supercollider:master Oct 18, 2020
@totalgee
Copy link

Thanks @brianlheim !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cmake option to disable LadspaUGen
4 participants