Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LadspaUGen optional #260

Merged
merged 2 commits into from
Oct 18, 2020
Merged

Make LadspaUGen optional #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f75fa9
make LadspaUGen optional but ON by default
gusano Jun 5, 2019
0f9de28
documentation: add a note about Ladspa issues
gusano Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ else()
endif()

option(AY "Build with AY ugens" ON)
option(LADSPA "Build with Ladspa ugen" ON)
option(QUARKS "Install plugins as quarks")
option(OSX_PACKAGE "Package dmg for Apple")
option(IN_PLACE_BUILD "Build and install in cmake build folder" ON)
Expand Down
14 changes: 11 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,19 +83,27 @@ ambisonics) subproject.
* (default on linux `/usr/local`)
* `cmake -DCMAKE_INSTALL_PREFIX=/usr/local ..`
+ Install in cmake build folder instead of `CMAKE_INSTALL_PREFIX`
* (OSX ONLY, default=ON)
* (macOS ONLY, default=ON)
* `cmake -DIN_PLACE_BUILD=ON`
+ Build the plugins as quarks
* (default 'OFF')
* (default=OFF)
* `cmake -DQUARKS=ON ..`
+ Build supernova-plugins
* (default 'OFF')
* (default=OFF)
* `cmake -DSUPERNOVA=ON ..`
+ Build Ladspa UGen
* (macOS AND LINUX ONLY, default=ON)
* `sc3-plugins/build/$ cmake -DLADSPA=ON ..`
+ Print all cmake options
* `sc3-plugins/build/$ cmake -L ..`

### Troubleshooting

#### Known issues

**On some Linux distributions** it has been reported that Ladspa UGen could prevent SuperCollider server from booting ([sc3-plugins/#210](https://github.com/supercollider/sc3-plugins/issues/210), [sc3-plugins/#23](https://github.com/supercollider/sc3-plugins/issues/23) and [supercollider/#4421](https://github.com/supercollider/supercollider/issues/4421)).
See above how to build sc3-plugins without Ladspa if needed.

#### Build errors

If you get an error while building that files are missing, it probably means that you didn't clone all the SuperCollider
Expand Down
6 changes: 3 additions & 3 deletions source/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ set(PLUGIN_DIRS_EXTRA
BetablockerUGens
ChaosUGens
DEINDUGens
LadspaUGen
MembraneUGens
NCAnalysisUGens
OteyPianoUGens
Expand Down Expand Up @@ -245,7 +244,8 @@ BUILD_PLUGIN(MembraneUGens "MembraneUGens/Membrane_shape.c;MembraneUGens/Membran
"" "MembraneUGens")

# LadspaUGen
if(NOT WIN32)
if(LADSPA AND NOT WIN32)
list(APPEND PLUGIN_DIRS_EXTRA LadspaUGen)
BUILD_PLUGIN(LadspaUGen "LadspaUGen/LadspaUGen.cpp;LadspaUGen/search.c" "${CMAKE_DL_LIBS}" "LadspaUGen")
add_executable(ladspalist LadspaUGen/ladspalist.c LadspaUGen/search.c)
target_link_libraries(ladspalist "${CMAKE_DL_LIBS}")
Expand Down Expand Up @@ -359,7 +359,7 @@ if (NOT APPLE)
DESTINATION ${INSTALL_DESTINATION})
endif()

if(NOT WIN32)
if(LADSPA AND NOT WIN32)
install(TARGETS ladspalist
DESTINATION ${INSTALL_DESTINATION_LADSPALIST})
endif()
Expand Down