Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish and continue #4231

Conversation

thecalcc
Copy link
Contributor

@thecalcc thecalcc commented Apr 5, 2023

No description provided.

@thecalcc thecalcc requested a review from tomaskikutis April 5, 2023 10:16
@tomaskikutis
Copy link
Member

here are the notes I took:

  • checkMediaAssociatedToUpdate - pass autosave only instead of scope
  • checkMediaAssociatedToUpdate - revert endpoint change, also item._id instead of rewriteOf
  • add types to $scope
  • publishItem - move out autosave, do in angular before invoking the fn
  • publishItem - move out angular specific action computation
  • remove lodashGet
  • checkMediaAssociatedToUpdate - add a return type
  • "After we publish the item a rewrite of the published item" <-- read response from fake scope instead

@thecalcc
Copy link
Contributor Author

thecalcc commented Apr 5, 2023

Also change the button from 'Nice' to 'P & C'

@tomaskikutis
Copy link
Member

scripts/apps/authoring-react/authoring-angular-integration.tsx - extract login into a separate function whether P & C is shown

@tomaskikutis
Copy link
Member

new version is not checking for privileges

improve the move of the logic so entire functions are moved, not only pieces copied as done now in order not to have hidden coupling

@thecalcc thecalcc mentioned this pull request Apr 20, 2023
@thecalcc thecalcc merged commit 4701af1 into superdesk:authoring-react-post-broadcasting Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants