Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close & continue #4233

Conversation

thecalcc
Copy link
Contributor

@thecalcc thecalcc commented Apr 7, 2023

No description provided.

@thecalcc thecalcc requested a review from tomaskikutis April 7, 2023 08:13
@thecalcc
Copy link
Contributor Author

thecalcc commented Apr 7, 2023

Add button in react authoring
Handle isDirty from angular in React

@tomaskikutis
Copy link
Member

Add button in react authoring
Handle isDirty from angular in React

do these and move out the logic from sdApi to authoringApiCommon

@thecalcc
Copy link
Contributor Author

After merging #4231 pull latest changes from post-broadcasting and reuse the new logic for C & C. Implement a new function to handle C & C conditional display.

@@ -383,6 +389,10 @@ function isEditable(_article: IArticle): boolean {
}
}

function rewrite(item: IArticle) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a return type?

@thecalcc thecalcc merged commit ce0357f into superdesk:authoring-react-post-broadcasting May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants