Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depot web schema #86

Merged
merged 3 commits into from
Jul 26, 2024
Merged

depot web schema #86

merged 3 commits into from
Jul 26, 2024

Conversation

billyb2
Copy link
Contributor

@billyb2 billyb2 commented Jul 24, 2024

No description provided.

@billyb2
Copy link
Contributor Author

billyb2 commented Jul 26, 2024

not sure why pre-commit is bugging out, that's the schema as generated from web

@billyb2 billyb2 marked this pull request as ready for review July 26, 2024 14:02
gwuah
gwuah reviewed Jul 26, 2024
View reviewed changes
resource_remote_builders.go Outdated Show resolved Hide resolved
gwuah
gwuah approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@gwuah gwuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but can you add some documentation on how you achieved all of this codegen, so it's easier for the next person. thanks!

@billyb2 billyb2 mentioned this pull request Jul 26, 2024
Merged
@billyb2 billyb2 merged commit 1a7b5f6 into main Jul 26, 2024
5 checks passed
@billyb2 billyb2 deleted the depot branch July 26, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbjohnson benbjohnson benbjohnson approved these changes

@gwuah gwuah gwuah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@billyb2 @benbjohnson @gwuah