-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support builds via depot.dev #3688
Conversation
This borrows code from dockerfileBuilder, but has some differences as depot is remote and can build and push to the fly registry directly. The CLI arguments followed the style of the nixpacks flags. To deploy using depot: - flyctl deploy --depot To run a machine: * flyctl machines run --build-depot Signed-off-by: Chris Goller <goller@gmail.com>
From there, we can just use the FromBuild mutation
Hello! I'm trying to review this PR by checking if it works locally: ❌ 2. Use the built flyctl.exe to run
|
ah whoops. a secret accidentally got overridden with the incorrect value. just fixed that. deploying should work fine now :) |
Awesome! I've re-run and the deploy succeeded with depot! 🎉 |
Here are the manual tests I've done to verify the commands work: Test if the commands work locally within a Laravel Fly app's project directory❓ flyctl deploy --depot
❓ flyctl machines run --build-depot
Check if the both commands work as expected in a CI environment
|
This borrows code from dockerfileBuilder, but has some differences as depot is remote and can build and push to the fly registry directly.
The CLI arguments followed the style of the nixpacks flags.
To deploy using depot:
To run a machine: