-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] OpenTelemetry Tracing resource merge error #2503
Comments
Ah, thanks! |
Would using httpconv "go.opentelemetry.io/otel/semconv/v1.20.0/httpconv"
semconv "go.opentelemetry.io/otel/semconv/v1.21.0" mismatch be an acceptable quick fix? I guess it technically makes the whole thing schema non-compliant and is not a future-proof solution but it makes traces show up correctly. I haven't found anything to replace |
Mmm I'm not sure, possibly... I'll try to have a fiddle with this before we do our next minor release. |
I'm a bit surprised this is causing an issue. There's many versions of the semantic conventions and it shouldn't be a stretch for v1.21 of the library to still request things be emitted with the v1.20 conventions. I can spend a bit on fixing this, but that's going to have to wait a week or two. Instead of trying to randomly cobble together a version of the conventions that sort of just happens to work, I'd suggest just rolling back the dependency to 1.20. We just update them from now and then, but there's no real need to do so here in this case. That would solve the immediate issue, and then we can spend some time fixing it in a future-proof way after. |
For some reason httpconv seems to have disappeared from 1.21, which results in a 1.21 runtime with 1.20 semconv/httpconv which seems to break some things. For now, this rolls the OTEL dependencies back to 1.20 which should fix the observability issues. We'll need to take a look at how to upgrade safely and correctly in the future. Relates to #2503.
For some reason httpconv seems to have disappeared from 1.21, which results in a 1.21 runtime with 1.20 semconv/httpconv which seems to break some things. For now, this rolls the OTEL dependencies back to 1.20 which should fix the observability issues. We'll need to take a look at how to upgrade safely and correctly in the future. Relates to #2503.
Describe the bug with a clear and concise description of what the bug is.
There is an uncaught error that occurs with tracing in
internal/tracing/tracing.go
:The error that occurs is "cannot merge resource due to conflicting Schema URL", and is caused by the mismatch of otel library versions being used is
v1.21.0
but the semconv schema version in use isv1.20.0
.Traces are still produced, but Grafana Tempo won't show them at all I guess due to missing attributes and they are shown funky in Jaeger too (they are shown as being produced by
OTLPResourceNoServiceName
instead ofGoToSocial
)Bumping the semconv schema version used to
v1.21.0
makes it work again but the problem is that the httpconv package was moved to being an internal package ofopentelemetry-go-contrib
starting fromv1.21.0
, so the version for it can't be bumped.What's your GoToSocial Version?
This occurs in all versions above v.11.0
GoToSocial Arch
No response
What happened?
OpenTelemetry traces don't show correctly in services that consume them
What you expected to happen?
That they would be shown correctly like they did in GoToSocial version v0.11.0
How to reproduce it?
Enable tracing grpc export to Grafana Tempo or Jaeger
Anything else we need to know?
No response
The text was updated successfully, but these errors were encountered: