[bugfix/tracing] fix broken tracing due to conflicting schema url #2712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The OpenTelemetry SDK is very strict about the schema version when the
Resource
is initialized.Specifically, different schema versions CANNOT be mixed, and since the default SDK resource (which is merged with the user-defined one) defines a schema URL, the
semconv
imports are really prone to being out-of-sync.The best way to avoid this is to merge a schemaless resource. This is fine...there's plenty of other ways to get
semconv
out of sync, and the core service attributes (e.g.service.name
) should not ever change.Additionally, any errors here are now propagated so that they'll be visible instead of silently swallowed.
Checklist
go fmt ./...
andgolangci-lint run
.