Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add OAuth2 recipe and introduce shouldTryLinkingWithSessionUser #927

Merged
merged 58 commits into from
Oct 3, 2024

Conversation

porcellus
Copy link
Collaborator

@porcellus porcellus commented Sep 23, 2024

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.
  • If added a new entry point, then make sure that it is importable by adding it to the exports in package.json

Remaining TODOs for this PR

  • Item1
  • Item2

porcellus and others added 30 commits June 9, 2024 17:16
* feat: Add recipe functions to update/delete OAuth2Client

* fix: PR changes
* feat: Add recipe functions to update/delete OAuth2Client

* fix: PR changes

* feat: Add recipe functions to get OAuth2Clients

* fix: PR changes

---------

Co-authored-by: Mihaly Lengyel <mihaly@lengyel.tech>
* feat: add initial oauth2 client apis

* feat: Add an api to get login info

* fix: merge issues and FE path

* fix: WIP fix for CSRF and redirection issues

* fix: OAuth2 fixes and test-server updates (#871)

* feat: update oauth2 login info endpoint types to match our general patterns

* fix: make login flow work

* feat!: improve how we handle changing email addresses and users becoming unverified when account linking requires verification (#869)

* feat: update email and pw change logic and add more security checks

* feat: update error messages

* refactor: improve debug logs and clarify conditions

* chore: update changelog

* chore: empty line from changelog

* refactor: remove duplicated check and bypass mapping for already mapped errcodes

* chore: update changelog

* feat: call isEmailChangeAllowed in pwless updateUser (#875)

* feat: call isEmailChangeAllowed in pwless updateUser

* test: add updateUser to test-server

* chore: remove unnecessary item from changelog

* chore: extend changelog to mention exact function names

* test: add logging to default overrides in test-server (#876)

* fix: circular dependency

* fix: fix types in oauth2 index exposed functions

* feat: add token building callbacks

* test: move the session object and claims to the BE sdk server (#879)

* fixes issue of refresh not clearing tokens

* adding dev-v18.0.2 tag to this commit to ensure building

---------

Co-authored-by: Ankit Tiwari <ankucodes@gmail.com>
Co-authored-by: rishabhpoddar <rishabh.poddar@gmail.com>
* feat: add initial oauth2 client apis

* feat: Add an api to get login info

* fix: merge issues and FE path

* fix: WIP fix for CSRF and redirection issues

* fix: OAuth2 fixes and test-server updates (#871)

* feat: update oauth2 login info endpoint types to match our general patterns

* fix: make login flow work

* fix: circular dependency

* feat: Add OAuth2Client recipe

* fix: PR changes

* fix: PR changes

* fix: PR changes

* fix: use correct userContext type

---------

Co-authored-by: Mihaly Lengyel <mihaly@lengyel.tech>
* fix: Remove internal redirects in the OAuth2 flow

* fix: PR changes
* feat: add initial oauth2 client apis

* feat: Add an api to get login info

* fix: merge issues and FE path

* fix: WIP fix for CSRF and redirection issues

* fix: OAuth2 fixes and test-server updates (#871)

* feat: update oauth2 login info endpoint types to match our general patterns

* fix: make login flow work

* fix: circular dependency

* feat: Add OAuth2Client recipe

* fix: PR changes

* fix: PR changes

* fix: PR changes

* feat: Add userInfoGET endpoint

* fix: PR changes

* fix: PR changes

* fix: PR changes

---------

Co-authored-by: Mihaly Lengyel <mihaly@lengyel.tech>
* feat: Add token revocation endpoint

* fix: PR changes

* fix: PR changes

* fix: PR changes

* fix: PR changes

* fix: PR changes

* fix: Add revocation_endpoint
* feat: Add token revocation endpoint

* fix: PR changes

* fix: PR changes

* fix: PR changes

* fix: PR changes

* feat: Add token introspection endpoint

* fix: PR changes

* fix: Add revocation_endpoint

* fix: PR changes

* fix: merge issue

---------

Co-authored-by: Mihaly Lengyel <mihaly@lengyel.tech>
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for astounding-pegasus-21c111 canceled.

Name Link
🔨 Latest commit 07b7bb2
🔍 Latest deploy log https://app.netlify.com/sites/astounding-pegasus-21c111/deploys/66fbb9a4210ac10008c3a022

Copy link

cloudflare-workers-and-pages bot commented Sep 24, 2024

Deploying supertokens-node-pr-check-for-edge-function-compat with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5d5e59e
Status: ✅  Deploy successful!
Preview URL: https://acafa9ce.supertokens-node-b95.pages.dev

View logs

deepjyoti30-st and others added 19 commits September 25, 2024 17:01
* Add changes to support unknown type in formField values

* Update email/password invalid type error message to be same as go/python sdk

* Add tests for invalid email/password in signup API

* Add tests for invalid email/password in token reset and reset API

* Update some errors to indicate unreachable errors

* Run build to generate build files

* Add detail about breaking change regarding formField value type change to unknown
* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* ci: experiment with manually runnable ci with pre-set branchnames

* fix: test fixing

* ci: experiment with manually runnable ci with pre-set branchnames

* test: make integration test server more stable

* ci: update ci runner script

* fix: adding hydra to circleci

* ci: add missing branch mapping

* fix: force script

* fix: update ci config

* fix: update ci config

* fix: update script

* fix: update script

* fix: update script

* fix: ory image

---------

Co-authored-by: Sattvik Chakravarthy <sattvik@gmail.com>
@porcellus porcellus changed the base branch from master to 20.1 October 1, 2024 22:39
@porcellus porcellus changed the base branch from 20.1 to 21.0 October 3, 2024 23:24
@porcellus porcellus merged commit 561ca5a into 21.0 Oct 3, 2024
30 of 55 checks passed
@porcellus porcellus deleted the feat/oauth2/base branch October 3, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants