Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing tests for domain parse util function #931

Merged

Conversation

deepjyoti30-st
Copy link
Contributor

Summary of change

This commit fixes the updated domain parse util function (that uses tldts) to make sure all tests pass.

Tests were failing as a side effect of #930 due to some behavioural changes between psl and tldts.

Related issues

Test Plan

Both config.test.js and utils.test.js should pass

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.
  • If added a new entry point, then make sure that it is importable by adding it to the exports in package.json

This commit fixes the updated domain parse util function (that uses
tldts) to make sure all tests pass.
Copy link

cloudflare-workers-and-pages bot commented Oct 1, 2024

Deploying supertokens-node-pr-check-for-edge-function-compat with  Cloudflare Pages  Cloudflare Pages

Latest commit: 352e58a
Status: ✅  Deploy successful!
Preview URL: https://57541fbe.supertokens-node-b95.pages.dev

View logs

@rishabhpoddar rishabhpoddar merged commit a59fa41 into 20.1 Oct 1, 2024
16 of 18 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/failing-tests-for-domain-parse-util-function branch October 1, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants