Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ExperimentalEmulator #85

Closed
wants to merge 21 commits into from
Closed

Improve ExperimentalEmulator #85

wants to merge 21 commits into from

Conversation

marcosfelt
Copy link
Collaborator

@marcosfelt marcosfelt commented Dec 30, 2020

This PR is a complete rewrite of the ExperimentalEmulator. The current implementation has not been giving good results on new training and is very difficult to debug. The debugging challenges are primarily due to the complexity of the training loops and the code organization.

This rewrite depends on pytorch-lightning, which simplifies and organizes training and validation code. It uses the LightningModule to centralize the training loop in the pytorch models and the LightningDataModule to automatically convert datasets + domains into dataloaders for pytorch.

Todo

  • Create BayesianRegressor using blitz-bayesian + pytorch-lightning
  • Create LightningDataModule
  • Set up Emulator with proper saving of model
  • Make sure to_dict and from_dict work on Emulator
  • Create model registry so custom models can be loaded using from_dict
  • Add transforms into LightningDataModule to handle categorical variables
  • Calculate evaluation scores on test set (RMSE, MAE)
  • Cross validation class for pytorch lightning
  • Retrain included models
  • Adjust tests as necessary
  • Set up to download pretrained models at runtime
  • Update docs as necessary

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@marcosfelt marcosfelt closed this Feb 16, 2021
This was referenced Feb 16, 2021
@marcosfelt marcosfelt deleted the emulator branch May 13, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant