-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skorch emulator #89
Merged
Merged
Skorch emulator #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This PR is a complete rewrite of the ExperimentalEmulator. The current implementation has not been giving good results on new training and is very difficult to debug. The debugging challenges are primarily due to the complexity of the training loops and the code organization.
This PR instead uses skorch, which provides a scikit-learn API for pytorch. This enables use of all of the scikit-learn preprocessing functionality, which I make heavy use of here.
The overall API has a similar feel to the old one. You create a domain, load in a dataset, instantiate the emulator, and start training. That's it.
Running that code gives this result:
One of the nice things is the ability to run grid search via cross-validation to identify hyperparameters:
Some additional features:
scripts/train_emulator
This also refactors and removes some dead code.