Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test to 1.8.0 #778

Merged
merged 3 commits into from
Aug 2, 2021
Merged

Update test to 1.8.0 #778

merged 3 commits into from
Aug 2, 2021

Conversation

bam241
Copy link
Member

@bam241 bam241 commented Aug 2, 2021

Upgrading test to 1.8.0

@bam241
Copy link
Member Author

bam241 commented Aug 2, 2021

@gonuke I did it as a rm commit then an add, GitHub still sees it as a mv....
I'll try again :)

@pshriwise
Copy link
Member

It's been quite a while since we updated gtest, so it's probably good to do so. Curious as to what motivated this PR though!

@bam241
Copy link
Member Author

bam241 commented Aug 2, 2021

we have problem on the windows side (see #727 ) it needs 1.8.0

@pshriwise
Copy link
Member

Cool, thanks!

@gonuke
Copy link
Member

gonuke commented Aug 2, 2021

I guess we'll just keep it as a mv...🤷

@gonuke
Copy link
Member

gonuke commented Aug 2, 2021

I'll merge after tests pass

@gonuke
Copy link
Member

gonuke commented Aug 2, 2021

Thanks @bam241

@gonuke gonuke merged commit 6eb430f into svalinn:develop Aug 2, 2021
@gonuke gonuke mentioned this pull request Aug 2, 2021
@bam241 bam241 deleted the update_ctest branch November 28, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants