fix: migration cleanup #10195
fix: migration cleanup #10195
Conversation
🦋 Changeset detectedLatest commit: 16c5057 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -10,7 +10,7 @@ export async function migrate() { | |||
| bail('Please re-run this script in a directory with a package.json'); | |||
| } | |||
|
|
|||
| console.log(colors.bold().yellow('\nThis will update files in the current directory\n')); | |||
| console.log(colors.bold().yellow('\nThis will update files in the current src/ directory\n')); | |||
There was a problem hiding this comment.
Is the path configurable?
Outside of Kit projects I've usually seen people put svelte files in client, app, components...
There was a problem hiding this comment.
It isn't right now. How could we go about it instead? Scan everything except node_modules / .svelte-kit or all things inside .gitignore? If a jsconfig/tsconfig exists and read the paths from there?
There was a problem hiding this comment.
Probably keep it simple and add a clack prompt. The automated solutions would still miss things, whereas people can just order it to do the right thing for their codebase with an input.
There was a problem hiding this comment.
Ahh, there is already a prompt for the transitions change. Great.
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
package.jsonPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.