-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migration cleanup #10195
Merged
Merged
fix: migration cleanup #10195
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9f2eda0
remove obsolete |local
dummdidumm 36c034e
migration guide link
dummdidumm 23b10ed
handle jsdoc
dummdidumm 7a8562b
prompt transition migration
dummdidumm 37e5d7f
log what is migrated
dummdidumm 6ae3dd8
changeset
dummdidumm e092bb6
update package.json
dummdidumm d11f813
folder prompt, guard against errors while migrating
dummdidumm ff45475
lint
dummdidumm c93957e
Update packages/migrate/migrations/svelte-4/migrate.js
dummdidumm cc75662
swap prompt order
dummdidumm 7363684
monorepo note
dummdidumm 16c5057
Update packages/migrate/migrations/svelte-4/migrate.js
dummdidumm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'svelte-migrate': patch | ||
--- | ||
|
||
fix: finalize svelte-4 migration |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the path configurable?
Outside of Kit projects I've usually seen people put svelte files in
client
,app
,components
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't right now. How could we go about it instead? Scan everything except
node_modules
/.svelte-kit
or all things inside.gitignore
? If a jsconfig/tsconfig exists and read the paths from there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably keep it simple and add a clack prompt. The automated solutions would still miss things, whereas people can just order it to do the right thing for their codebase with an input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, there is already a prompt for the transitions change. Great.