[feat] use the Vite server options in dev mode #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9899659 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Aug 17, 2021
5 tasks
benmccann
force-pushed
the
vite-server
branch
3 times, most recently
from
79ccb38 to
d4065b3
Compare
benmccann
force-pushed
the
vite-server
branch
2 times, most recently
from
1510d2c to
4abf326
Compare
benmccann
force-pushed
the
vite-server
branch
from
4abf326 to
dbcee51
Compare
benmccann
changed the title
benmccann
force-pushed
the
vite-server
branch
from
5ff44d3 to
85f8690
Compare
benmccann
force-pushed
the
vite-server
branch
from
85f8690 to
9899659
Compare
5 tasks
sidharthv96
added a commit
to sidharthv96/kit
that referenced
this pull request
Sep 19, 2021
* 'master' of https://github.com/sveltejs/kit: (322 commits) Version Packages (next) (sveltejs#2438) [fix] revert sveltejs#2354 and fix double character decoding a different way (sveltejs#2435) chore: update dependencies (sveltejs#2447) [docs] add link to envPrefix option in env var FAQ (sveltejs#2445) Fix invalid changeset. Thanks GitHub bot :-p [feat] use the Vite server options in dev mode (sveltejs#2232) [fix] provide valid value for `letter-spacing` CSS property in template (sveltejs#2437) [docs] fix typo (sveltejs#2443) [fix] add svelte field when packaging (sveltejs#2431) Version Packages (next) (sveltejs#2428) [chore] update lockfile [fix] update to TS 4.4.3 (sveltejs#2432) [chore] add links to repository and homepage to package.json (sveltejs#2425) docs: use fragment for prefetching link (sveltejs#2429) [fix] encodeURI during prerender (sveltejs#2427) Version Packages (next) (sveltejs#2420) revert change to versioning during release workflow chore: update vite-plugin-svelte (sveltejs#2423) [chore] expose Body generic to hook functions (sveltejs#2413) [feat] adapter-node entryPoint option (sveltejs#2414) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
This PR adds the SvelteKit middleware after the Vite-provided middlewares using a Vite plugin
Why
People get confused by the presence of Vite server options that mostly don't do anything today.
We also have to create a lot of duplicate functionality. With this change we possibly could delete everything that's in the
serverfolder today in a follow-up PR.Other considerations
Right now, using Node middleware in dev and prod are very different from one another. We could also consider a separate change that would expose the middleware creation function to allow the user to utilize the Kit middleware in dev mode with their own server. This change would make that just ever so-slightly harder because that function would need to set
middlewareMode: trueand this PR is removing that default setting. (Another potential solution to that problem might be to see if we could make adapters into Vite plugins, but now we're getting way off topic 😆 )