-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add homepage to package.json #2425
Conversation
🦋 Changeset detectedLatest commit: a4b703f The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Any changes to this file should be indented with tabs like the rest of the file, not with spaces. I'm not sure how valuable of a change this is, but I would argue that, if we did add a homepage, it should be https://kit.svelte.dev/ - There is a separate |
Done. |
Where does this information appear? We have this info in the root package, and if we wanted to put it in sub-packages, we'd want to put it into all of them rather than just one. |
This will appear on npm, there will be links to the homepage/github repo then, which I agree should be done for all packages. To me it's always a little strange to see a package on npm without any link to github, which makes me think it's closed source or something like that. |
this change seems like a good idea to me, but agree that it should be done for everything under |
Done! |
I was starting to suggest that the Lgtm! |
Is this supposed to be visible on npm? I don't see it https://www.npmjs.com/package/@sveltejs/adapter-static/v/1.0.0-next.19 |
It should be, but maybe it's because npm only parses the links based on the |
* 'master' of https://github.com/sveltejs/kit: (322 commits) Version Packages (next) (sveltejs#2438) [fix] revert sveltejs#2354 and fix double character decoding a different way (sveltejs#2435) chore: update dependencies (sveltejs#2447) [docs] add link to envPrefix option in env var FAQ (sveltejs#2445) Fix invalid changeset. Thanks GitHub bot :-p [feat] use the Vite server options in dev mode (sveltejs#2232) [fix] provide valid value for `letter-spacing` CSS property in template (sveltejs#2437) [docs] fix typo (sveltejs#2443) [fix] add svelte field when packaging (sveltejs#2431) Version Packages (next) (sveltejs#2428) [chore] update lockfile [fix] update to TS 4.4.3 (sveltejs#2432) [chore] add links to repository and homepage to package.json (sveltejs#2425) docs: use fragment for prefetching link (sveltejs#2429) [fix] encodeURI during prerender (sveltejs#2427) Version Packages (next) (sveltejs#2420) revert change to versioning during release workflow chore: update vite-plugin-svelte (sveltejs#2423) [chore] expose Body generic to hook functions (sveltejs#2413) [feat] adapter-node entryPoint option (sveltejs#2414) ...
Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0