Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Invalidating a route now fires sveltekit:navigation-start event #2609

Conversation

henninggross
Copy link

Closes #2528

By now also calling router.notify() when invalidating an URL it is made sure that the sveltekit:navigation-start event is fired upon invalidation.
This way one can for example show a loading indicator when trying to reload the same page.

I am calling router.notify() instead of just dispatching the sveltekit:navigation-start event to also update navigating.

Other than that it is just more consistent to have a start event when also having an end event as one could expect both to be fired the same way they are when navigating normally.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2021

🦋 Changeset detected

Latest commit: 84ee7b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann changed the title Invalidating a route now fires sveltekit:navigation-start event [fix] Invalidating a route now fires sveltekit:navigation-start event Oct 16, 2021
@benmccann
Copy link
Member

This doesn't seem quite right to me because, if the page URL doesn't change, I'm not sure we should be firing navigation-start and navigation-end

@benmccann
Copy link
Member

Thanks for this. I took another stab at it in #2649

@benmccann benmccann closed this Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sveltekit:invalidate-start and sveltekit:invalidate-end events
2 participants