[fix] fire navigation-end event only at end of navigation #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 487c61c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
benmccann
force-pushed
the
nav-events
branch
2 times, most recently
from
b52991a to
cb05e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug portion of #2528. Stops us from firing
navigation-endevent caused by invalidate or by a redirect during renderingAlso fixes multiple issues with the tests. Need to start listening for
navigation-endat the same time we click to avoid race condition. Also need to cancel timeout or else test will fail if the rest of the test takes more than two seconds. Finally,clicknavis to be used only for internal navigation and not navigation that does a server-side nav (e.g. one test was listening fornavigation-endwhen going to google.com, but I'm not sure that makes sense since that site clearly won't fire the event)