You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I spent a few hours this morning debugging why a popstate event during navigation to one of my pages would result in the target page content being displayed at the previous page url. Turns out I have an endpoint at the same url as the target page and the client router was performing location.reload(). That code path didn't correctly handle a popstate while reloading. That codepath is no longer possible after #2656 because it removes the endpoint routes from the client manifest, but I noticed the location.reload() logic is still present. This PR cleans that up.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.
Tests
Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
Changesets
If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Is this fixing a specific bug or just tidying up unused code? If it's tidying up code, I don't think it needs a changeset. If it's fixing a bug, is it possible to have a test for it?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent a few hours this morning debugging why a
popstateevent during navigation to one of my pages would result in the target page content being displayed at the previous page url. Turns out I have an endpoint at the same url as the target page and the client router was performinglocation.reload(). That code path didn't correctly handle apopstatewhile reloading. That codepath is no longer possible after #2656 because it removes the endpoint routes from the client manifest, but I noticed thelocation.reload()logic is still present. This PR cleans that up.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0