Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused reload flag on NavigationResult #2964

Merged
merged 2 commits into from
Dec 3, 2021
Merged

remove unused reload flag on NavigationResult #2964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53dfef4
remove unused reload flag on NavigationResult
moatra Dec 1, 2021
e3a24d9
delete unnecessary changeset
moatra Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/kit/src/runtime/client/renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,7 @@ export class Renderer {
}
}

if (navigation_result.reload) {
location.reload();
} else if (this.started) {
if (this.started) {
this.current = navigation_result.state;

this.root.$set(navigation_result.props);
Expand Down
1 change: 0 additions & 1 deletion packages/kit/src/runtime/client/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export type NavigationCandidate = {
};

export type NavigationResult = {
reload?: boolean;
redirect?: string;
state: NavigationState;
props: Record<string, any>;
Expand Down