Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace %svelte.body% etc with %sveltekit.body% #5016

Merged
merged 3 commits into from
May 23, 2022

Conversation

Rich-Harris
Copy link
Member

Never got round to creating an issue for this, but I think it's a no-brainer — we should have been more explicit from the start that %namespace.body% is a SvelteKit thing, not a Svelte thing

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 21, 2022

🦋 Changeset detected

Latest commit: 89ce7f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
create-svelte Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this the other day and was also thinking it's inconsistent with what we've done elsewhere

.changeset/olive-lies-train.md Outdated Show resolved Hide resolved
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@elliott-with-the-longest-name-on-github
Copy link
Contributor

@Rich-Harris

While we're at it, the root context for $app/stores is called __svelte__ (see here). Seems like renaming it to __sveltekit__ would fit well with this PR?

@Rich-Harris
Copy link
Member Author

We can make the __svelte__ change separately since it's internal rather than external — it would probably be better to use a private object as the key rather than a magic string, but I don't know off the top of my head if that'd be a rabbit hole

@Rich-Harris Rich-Harris mentioned this pull request May 23, 2022
@Rich-Harris Rich-Harris merged commit daef4b0 into master May 23, 2022
@Rich-Harris Rich-Harris deleted the template-placeholders branch May 23, 2022 14:45
camargo added a commit to NASA-AMMOS/aerie-ui that referenced this pull request May 24, 2022
- Update '%sveltekit.body%' from
sveltejs/kit#5016
JosephVolosin pushed a commit to NASA-AMMOS/aerie-ui that referenced this pull request Aug 20, 2024
- Update '%sveltekit.body%' from
sveltejs/kit#5016
JosephVolosin pushed a commit to NASA-AMMOS/aerie-ui that referenced this pull request Oct 21, 2024
- Update '%sveltekit.body%' from
sveltejs/kit#5016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants