-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace %svelte.body%
etc with %sveltekit.body%
#5016
Conversation
🦋 Changeset detectedLatest commit: 89ce7f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this the other day and was also thinking it's inconsistent with what we've done elsewhere
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
While we're at it, the root context for |
We can make the |
- Update '%sveltekit.body%' from sveltejs/kit#5016
- Update '%sveltekit.body%' from sveltejs/kit#5016
- Update '%sveltekit.body%' from sveltejs/kit#5016
Never got round to creating an issue for this, but I think it's a no-brainer — we should have been more explicit from the start that
%namespace.body%
is a SvelteKit thing, not a Svelte thingPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0