Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace svelte.[assets|head|body] by sveltekit.[assets|head|body] #344

Closed
wants to merge 1 commit into from
Closed

fix: replace svelte.[assets|head|body] by sveltekit.[assets|head|body] #344

wants to merge 1 commit into from

Conversation

stephane-klein
Copy link

@vercel
Copy link

vercel bot commented May 26, 2022

@stephane-klein is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented May 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hn ❌ Failed (Inspect) May 26, 2022 at 11:33AM (UTC)

@stephane-klein
Copy link
Author

@Rich-Harris 🙂

@benmccann
Copy link
Member

Did you test this locally? I expect that it'd break the site because you're not bumping the SvelteKit version to a version where this change is present

@stephane-klein
Copy link
Author

@benmccann without this Pull Request commit:

$ cd sites/hn.svelte.dev
$ npm list
hn.svelte.dev@0.0.1 /home/stephane/git/github.com/sveltejs/sites/sites/hn.svelte.dev
├── @sveltejs/adapter-auto@1.0.0-next.48
├── @sveltejs/kit@1.0.0-next.345
├── prettier-plugin-svelte@2.7.0
├── prettier@2.6.2
└── svelte@3.48.0
$ npm run dev

I go to http://127.0.0.1.3000 and I get this error:

Error: %svelte.assets% in src/app.html should be replaced with %sveltekit.assets%
    at load_template (file:///home/stephane/git/github.com/sveltejs/sites/sites/hn.svelte.dev/node_modules/@sveltejs/kit/dist/cli.js:792:10)
    at file:///home/stephane/git/github.com/sveltejs/sites/sites/hn.svelte.dev/node_modules/@sveltejs/kit/dist/chunks/index.js:301:24

More info see sveltejs/kit#5016

@benmccann question: do you think that this pull request don't fix this breaking change?

@benmccann
Copy link
Member

It's because the instructions were showing npm instead of pnpm: a4ffe64

This change will break users who use pnpm because the lockfile isn't being updated as well

@benmccann
Copy link
Member

closing in favor of #345

@benmccann benmccann closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants