Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] fix migration test linting #5901

Merged
merged 3 commits into from
Aug 16, 2022
Merged

[chore] fix migration test linting #5901

merged 3 commits into from
Aug 16, 2022

Conversation

benmccann
Copy link
Member

lint is failing on #5861. this should fix it

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: ff9a051

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

benmccann
benmccann commented Aug 16, 2022
View reviewed changes
packages/migrate/migrations/routes/migrate_page_server/index.spec.js
@@ -5,7 +5,7 @@ import { migrate_page_server } from './index.js';

for (const sample of read_samples(import.meta.url)) {
test(sample.description, () => {
const actual = migrate_page_server(sample.before, sample.filename);
const actual = migrate_page_server(sample.before, sample.filename ?? '+page.server.js');
Copy link
Member Author

@benmccann benmccann Aug 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this defaulting be done inside the method? I.e. make the second parameter optional

Or should the samples all have a filename?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code is saying that all samples implicitly do have a filename, +page.server.js, unless one is specified. making the parameter optional for the sake of the tests is the wrong solution

@Rich-Harris Rich-Harris merged commit ad243c5 into sveltejs:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmccann @Rich-Harris